Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "fix: missing js sourcemaps with rewritten imports broke debugging (#7767) (#9476)" #11144

Merged
merged 1 commit into from
Dec 3, 2022

Conversation

benmccann
Copy link
Collaborator

@benmccann benmccann commented Dec 1, 2022

Description

This reverts commit 3fa96f6. FYI @BenceSzalai

This is causing SvelteKit's source map test to fail with an incorrect location. See the failing tests on this branch: sveltejs/kit#7543

To move forward, we can do something along the lines of:

  1. commit this PR to revert back to the old behavior
  2. update the issue with the additional information we've learned
  3. start a new PR, add 2 testcases that a) check stacktrace positions with line and column and b) sourcemap accuracy in general (may initially fail due to importanalysis updates not being recorded)
  4. implement proper sourcemap support for importanalysis in dev (test should pass now)
  5. test perf impact by comparing main with that PR
  6. if 5 shows low to no impact, just change the behavior, if it shows slowdowns, add an option
  7. merge PR for 4.1

Additional context

Discussion on Discord in #ecosystem-ci thread 2022113-sveltekit:
https://discord.com/channels/804011606160703521/1047380773990314004/1047447169168310328


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@benmccann benmccann changed the title Fix: Revert "fix: missing js sourcemaps with rewritten imports broke debugging (#7767) (#9476)" fix: Revert "fix: missing js sourcemaps with rewritten imports broke debugging (#7767) (#9476)" Dec 2, 2022
@sapphi-red sapphi-red added the regression The issue only appears after a new release label Dec 2, 2022
@patak-dev patak-dev merged commit fdc6f3a into vitejs:main Dec 3, 2022
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression The issue only appears after a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants