Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: formatError() outside rollup context #11156

merged 1 commit into from
Dec 4, 2022


Copy link


Fix formatError() to be able to compute the error frame outside the activeCtx (useful for SSR rendering if app crashes during execution).

Right now formatError() is not generating the frame automatically, even though throwing a error with all the necessary information.

When using Vite with dev SSR, custom user's code might run right after ssrLoadModule() and this code could crash, right now it's is missing nice printing, even though the source of the error is known!

Additional context

Discussion with @patak-dev

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev merged commit 2aee2eb into vitejs:main Dec 4, 2022
Copy link


@manucorporat manucorporat deleted the fix-format-error branch December 6, 2022 11:59
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants