Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: specify that 'worker' means 'web worker' #11260

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

mikemaccana
Copy link
Contributor

Description

https://vitejs.dev/config/worker-options.html just says worker options - it's unclear whether these are web workers or service workers. https://vitejs.dev/guide/features.html#web-workers seems to indicate 'workers' means web workers.

What is the purpose of this pull request?

  • Documentation update

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@benmccann benmccann added the documentation Improvements or additions to documentation label Dec 12, 2022
@patak-dev patak-dev changed the title Specify that 'worker' means 'web worker' not 'service worker'. docs: specify that 'worker' means 'web worker' Dec 14, 2022
@patak-dev patak-dev merged commit 44fb01a into vitejs:main Dec 14, 2022
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants