Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update esbuild to 0.16.2 #11265

Merged
merged 1 commit into from Dec 8, 2022
Merged

chore: update esbuild to 0.16.2 #11265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vite/package.json
View file
Open in desktop
Expand Up @@ -58,7 +58,7 @@
},
"//": "READ CONTRIBUTING.md to understand what to put under deps vs. devDeps!",
"dependencies": {
"esbuild": "^0.16.1",
"esbuild": "^0.16.2",
"postcss": "^8.4.19",
"resolve": "^1.22.1",
"rollup": "^3.6.0"
Expand Down
2 changes: 0 additions & 2 deletions packages/vite/src/node/plugins/esbuild.ts
View file
Open in desktop
Expand Up @@ -128,8 +128,6 @@ export async function transformWithEsbuild(
}

const resolvedOptions = {
// esbuild 0.16.0 & 0.16.1 defaults to 'browser': https://github.com/evanw/esbuild/issues/2718
platform: 'neutral',
Comment on lines -131 to -132
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting this will make <script> to be escaped because platform: 'browser' enables that feature.
https://github.com/evanw/esbuild/blob/main/CHANGELOG.md#0162:~:text=Provide%20a%20way,break%20the%20code%3A

Before esbuild 0.16.0, this was happening.

sourcemap: true,
// ensure source file name contains full query
sourcefile: filename,
Expand Down
140 changes: 70 additions & 70 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.