Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rebuilds don't happen in watch mode after the first rebuild throws an error during the load function #11605

Closed
wants to merge 1 commit into from

Conversation

Generalsimus
Copy link
Contributor

@Generalsimus Generalsimus commented Jan 5, 2023

Rebuilds don't happen in watch mode after the first rebuild throws an error during the load function.

The position of the watcher changed so that the file review would start before the load function is executed, and in the event of an error, the primary renderer will not crash and the file will be able to be watched.

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

… error during the load function.

The position of the watcher changed so that the file review would start before the load function is executed, and in the event of an error, the primary renderer will not crash and the file will be able to be watched.
@Generalsimus Generalsimus changed the title Rebuilds don't happen in watch mode after the first rebuild throws an error during the load function. rebuilds don't happen in watch mode after the first rebuild throws an error during the load function Jan 5, 2023
@Generalsimus Generalsimus changed the title rebuilds don't happen in watch mode after the first rebuild throws an error during the load function fix: rebuilds don't happen in watch mode after the first rebuild throws an error during the load function Jan 5, 2023
@Generalsimus Generalsimus closed this by deleting the head repository Jan 5, 2023
@Generalsimus Generalsimus reopened this Jan 5, 2023
Copy link
Contributor Author

@Generalsimus Generalsimus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: rebuilds don't happen in watch mode after the first rebuild throws an error during the load function

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. For reference, in the import analysis plugin, we are also calling ensureEntryFromUrl before the file is loaded while we are rewriting the imports.

@patak-dev patak-dev added the p3-minor-bug An edge case that only affects very specific usage (priority) label Apr 6, 2023
@patak-dev
Copy link
Member

Closing this PR as the branch was deleted, let's continue working here: #12774

@patak-dev patak-dev closed this Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants