Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: await bundle closing #11873

Merged
merged 1 commit into from
Feb 1, 2023
Merged

fix: await bundle closing #11873

merged 1 commit into from
Feb 1, 2023

Conversation

benmccann
Copy link
Collaborator

Description

Vite does not await when calling bundle.close which causes code expected to run after the closeBundle plugin hook to run before it instead

Closes vite-pwa/sveltekit#21

Additional context

A recent refactoring in SvelteKit caused this issue to be hit extremely frequently

Vite does do an await in the other location where it calls bundle.close:

await bundle.close()


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@benmccann benmccann added bug p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) labels Feb 1, 2023
@bluwy bluwy merged commit 1e6768d into vitejs:main Feb 1, 2023
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SvelteKit 1.3.1+ not working
2 participants