Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): handle pure css chunk heuristic with special queries #12091

Merged
merged 2 commits into from
Feb 18, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Feb 17, 2023

Description

When deciding whether a chunk is a pure css chunk, it's incorrect when there is modules of:

  1. /project/src/style.css
  2. /project/src/style.css?url

The ?url should make this not a pure css chunk, since that includes JS. Otherwise Vite would remove the pure css chunk from the bundle, causing a runtime import error.

Fixes withastro/astro#6203

Additional context

This PR should also make detecting pure css chunks slightly optimal.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added feat: css p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) labels Feb 17, 2023
@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Feb 17, 2023

📝 Ran ecosystem CI: Open

suite result
astro ✅ success
histoire ✅ success
iles ✅ success
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt-framework ✅ success
previewjs ✅ success
qwik ❌ failure
rakkas ✅ success
sveltekit ✅ success
vite-plugin-ssr ✅ success
vite-plugin-react ✅ success
vite-plugin-react-pages ✅ success
vite-plugin-react-swc ✅ success
vite-plugin-svelte ✅ success
vite-plugin-vue ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success
windicss ✅ success

faga295
faga295 previously approved these changes Feb 17, 2023
@patak-dev patak-dev merged commit a873af5 into main Feb 18, 2023
@patak-dev patak-dev deleted the fix-pure-css-chunk branch February 18, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: css p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing CSS URLs break server startup
3 participants