Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): should not rebase http url for less (fix: #12155) #12195

Merged
merged 2 commits into from
Feb 25, 2023
Merged

fix(css): should not rebase http url for less (fix: #12155) #12195

merged 2 commits into from
Feb 25, 2023

Conversation

sun0day
Copy link
Member

@sun0day sun0day commented Feb 25, 2023 •
edited

Description

fix #12155

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sun0day
Copy link
Member Author

sun0day commented Feb 25, 2023

I'd like add a test case for importing css from external HTTP url. But not sure which url to add.

bluwy
bluwy requested changes Feb 25, 2023
View reviewed changes
packages/vite/src/node/plugins/css.ts Outdated Show resolved Hide resolved
@bluwy bluwy added feat: css p3-minor-bug An edge case that only affects very specific usage (priority) labels Feb 25, 2023
@bluwy bluwy changed the title fix(css): should not rebase http url (fix: #12155) fix(css): should not rebase http url for less (fix: #12155) Feb 25, 2023
@bluwy bluwy enabled auto-merge (squash) February 25, 2023 09:20
@bluwy bluwy merged commit 9cca30d into vitejs:main Feb 25, 2023
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@sun0day @futurGH
fix(css): should not rebase http url for less (fix: vitejs#12155) (vi…
ca76964 
…tejs#12195)
@sun0day sun0day mentioned this pull request Mar 2, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
feat: css p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

less inline import for http urls is not working
2 participants
@sun0day @bluwy