Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-vite): ignore TypeScript *.tsbuildinfo files #12590

Closed
wants to merge 2 commits into from

Conversation

karlhorky
Copy link
Contributor

@karlhorky karlhorky commented Mar 26, 2023

Description

Ignore the *.tsbuildinfo incremental compilation files generated by TypeScript when running tsc with a project that does not configure "noEmit": true, eg. the tsconfig.node.json config:

$ npx tsc --project tsconfig.node.json 

These can be safely ignored: TypeScript docs

These .tsbuildinfo files can be safely deleted and don’t have any impact on our code at runtime

Additional context

This changes the .gitignore files in all TypeScript templates that I could see. If there's anywhere else that I should add this change, happy to do so.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Generated if running tsc with a project that does not configure "noEmit": true, eg. the tsconfig.node.json:

```bash
$ npx tsc --project tsconfig.node.json 
```
@stackblitz
Copy link

stackblitz bot commented Mar 26, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@karlhorky karlhorky marked this pull request as ready for review March 26, 2023 14:02
@karlhorky karlhorky changed the title Ignore TypeScript *.tsbuildinfo files fix: ignore TypeScript *.tsbuildinfo files Mar 26, 2023
@karlhorky karlhorky changed the title fix: ignore TypeScript *.tsbuildinfo files fix(create-vite): ignore TypeScript *.tsbuildinfo files Mar 30, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it doesn't hurt to add. Can you help rebase this and add it for the new qwik-ts and solid-ts templates too?

@bluwy
Copy link
Member

bluwy commented May 18, 2024

Closing this for now as it has gone stale. We may also go with #15913 instead.

@bluwy bluwy closed this May 18, 2024
@karlhorky karlhorky deleted the patch-1 branch May 18, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants