Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: throw element not found error #12665

Merged
merged 2 commits into from
Mar 30, 2023
Merged

test: throw element not found error #12665

merged 2 commits into from
Mar 30, 2023

Conversation

sun0day
Copy link
Member

@sun0day sun0day commented Mar 30, 2023

Description

Sometimes toEl fails to find the element in CI, which will cause el.evaluate throw the error Cannot read properties of null (reading 'evaluate') and the error stack position is incorrect, it's hard to debug which test case fails.

e.g

image

There is no getBg call in this test case actually 馃槩

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Mar 30, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

playground/test-utils.ts Outdated Show resolved Hide resolved
@bluwy bluwy enabled auto-merge (squash) March 30, 2023 17:13
@bluwy bluwy merged commit 1f011d8 into vitejs:main Mar 30, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants