Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): set NODE_ENV at build #1446

Closed
wants to merge 2 commits into from
Closed

fix(build): set NODE_ENV at build #1446

wants to merge 2 commits into from

Conversation

underfin
Copy link
Member

@underfin underfin commented Jan 9, 2021

fix #1445

@yyx990803
Copy link
Member

Sorry, didn't see this when I pushed d7ceabe - there are some additional edge cases to be handled.

@yyx990803 yyx990803 closed this Jan 9, 2021
@underfin underfin deleted the NODE_ENV-for-build branch January 10, 2021 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

process.env.NODE_ENV not set to production
2 participants
@underfin @yyx990803