Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(prebundling): remove uncertain warning #14586

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 11, 2023

Description

In spirit of Sarah's ViteConf talk, I never quite grasp how this warning fixes things. I even tried to rephrase it at #7008. So removing in this PR.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@bluwy bluwy added the documentation Improvements or additions to documentation label Oct 11, 2023
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Sarah effect

@patak-dev patak-dev merged commit c558ae5 into main Oct 11, 2023
10 checks passed
@patak-dev patak-dev deleted the remove-prebundle-warning branch October 11, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants