chore: remove server.host
option for e2e test
#14606
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An edge case I encountered. Ports 5173 are occupied by another
vite
server that uses theserver.host
option by default. When I runpnpm test-serve
, the test server willlisten()
successfully. Normally it should fail and then start port 5174 but it doesn't.I noticed
server.host = true
in e2e test, so the host isundefined
. According to the documentation described as followsSo the http server may not listen to
localhost
. maybe192.168.xx.xx
or else.The solution to this issue is easy, just use
network[0]
instead oflocal[0]
will workAdditional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).