feat(server)!: use parcel watcher #14731
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Decided to give #13593 another shot before deciding if we should fit it into Vite 5. But with the state of the implementation, I don't think it's feasible (for now).
This PR implements a hybrid
@parcel/watcher
+fs.watch
approach, where the former is used forroot
recursive watching, and the latter for non-recursive watching. parcel-bundler/watcher#92It also implements
chokidar
's watcher interface for better compatibility. Ultimately it feels like I'm re-implementingchokidar
and would be better as a standalone library, but it's easier to test this way for now.Additional context
WIP TODO:
getWatched
compatibleunwatch
andadd
on the same path should continue watchingunlinkDir
not correctly detectedWhat is the purpose of this pull request?