docs: note skipLibCheck #14932
Merged
docs: note skipLibCheck #14932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluwy
commented
Nov 10, 2023
| @@ -111,7 +111,9 @@ As such, it is recommended to set `target` to `ESNext` or `ES2022` or newer, or | |||
| - [`experimentalDecorators`](https://www.typescriptlang.org/tsconfig#experimentalDecorators) | |||
| - [`alwaysStrict`](https://www.typescriptlang.org/tsconfig#alwaysStrict) | |||
|
|
|||
| If migrating your codebase to `"isolatedModules": true` is an insurmountable effort, you may be able to get around it with a third-party plugin such as [rollup-plugin-friendly-type-imports](https://www.npmjs.com/package/rollup-plugin-friendly-type-imports). However, this approach is not officially supported by Vite. | |||
There was a problem hiding this comment.
Removed this as there's type imports and verbatimModuleSyntax to solve this today.
sapphi-red
approved these changes
Nov 10, 2023
patak-dev
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
close #7867
Figured it was easier to document in a single place than in all the
tsconfig.json, it's been quite some time since we setskipLibCheck: trueand it worked fine imo 馃槄What is the purpose of this pull request?