Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: symbolic links in public dir #15264

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

patak-dev
Copy link
Member

Fixes #15261

Description

#15195 introduced a regression for symbolic links in the public directory. For now, we revert back to the regular check if there are symbolic links to fix it.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Copy link

stackblitz bot commented Dec 6, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev patak-dev requested a review from bluwy December 6, 2023 15:36
@patak-dev patak-dev added regression The issue only appears after a new release p3-minor-bug An edge case that only affects very specific usage (priority) labels Dec 6, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 Yeah we can look into a more cleaner way to handle for symlinks in the future.

@patak-dev patak-dev merged commit ef2a024 into main Dec 6, 2023
15 checks passed
@patak-dev patak-dev deleted the fix/symbolic-links-in-public-dir branch December 6, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority) regression The issue only appears after a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v5] content of symlink in public folder do not resolve
2 participants