Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default sideEffect option is delivered to rollup #15665

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

XiSenao
Copy link
Collaborator

@XiSenao XiSenao commented Jan 20, 2024

Description

fix: #15660

Additional context

I think the priority of sideEffect in package.json is higher than the moduleSideEffects configuration in rollup, and the configuration takes precedence over the default value true. When the sideEffect option is not specified in package.json, pass null value to rollup. rollup will determine the value of moduleSideEffects based on the treeshake.moduleSideEffects configuration item or a fallback default value of true.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Jan 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@XiSenao XiSenao added the p3-minor-bug An edge case that only affects very specific usage (priority) label Jan 20, 2024
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. It seems to be what @rollup/plugin-node-resolve does too: https://github.com/rollup/plugins/blob/2a19079892f0bef53b557da965339cdef0a13a93/packages/node-resolve/src/util.js#L100

@patak-dev patak-dev merged commit f6cf3d1 into vitejs:main Jan 22, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite not tree-shaking extra rollup inputs
3 participants