fix: cachedTransformMiddleware for direct css requests #15919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
patak-dev
added
p3-minor-bug
|
The backend-integration test that imports a CSS file and also linked it was failing if we only avoid the optimization for direct requests. So the PR now bails out of it for all CSS files. |
danielroe
approved these changes
Feb 15, 2024
patak-dev
deleted the
fix/cached-transform-middleware-for-direct-css-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes ttps://github.com/danielroe/css-flash-repro
The check we added in #15586 to detect mixed etags between direct and imported CSS was wrong. See explanation here to understand the problem: https://github.com/vitejs/vite/pull/15586/files#r1453060051. The issue is that
isDirectRequestdoesn't work because the query isn't added until the transform middleware kicks in.This PR fixes the issue by reverting back to the previous 304 scheme for direct CSS requests. Imported CSS and all JS files will still go through the optimized path.
If we move from
?directto marking with?importas we do with assets, we may be able to optimize direct CSS imports too.What is the purpose of this pull request?