Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sideEffects: [] should work as sideEffects: false #16152

Merged
merged 1 commit into from Mar 13, 2024

Conversation

sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Mar 13, 2024

Description

When an empty array is passed to createFilter, it works as () => true. But we want it to work as () => false instead here.

If options.include is omitted or has zero length, filter will return true by default.
https://github.com/rollup/plugins/blob/master/packages/pluginutils/README.md#createfilter

fixes #14558

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Mar 13, 2024
Copy link

stackblitz bot commented Mar 13, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev
Copy link
Member

/ecosystem-ci run

@patak-dev patak-dev merged commit f377a84 into vitejs:main Mar 13, 2024
11 checks passed
@sapphi-red sapphi-red deleted the fix/sideeffects-empty branch March 13, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sideEffects: false results in much larger output
3 participants