Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(static-deploy): add xmit deployment guide #16441

Merged
merged 1 commit into from May 1, 2024

Conversation

pcarrier
Copy link
Contributor

Description

Offers another option for Vite app hosting.

Copy link

stackblitz bot commented Apr 17, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@pcarrier pcarrier changed the title static-deploy.md: add xmit feat: add xmit to static-deploy.md Apr 17, 2024
@bluwy
Copy link
Member

bluwy commented Apr 30, 2024

Hi @pcarrier. Thanks for submitting this! On this page, we'd like to keep the options limited to free tiers only. It's not clear if https://xmit.co offers so since the blog shows needing to purchase a domain from namecheap.

Is it possible to skip that step? Or does https://xmit.co offer temporary subdomain hosting? If so, it would be nice to clarify that in the blog too.

I realized we didn't explicitly explain the requirements to add additional sections here, so I'll send a PR soon to improve this.

@pcarrier
Copy link
Contributor Author

No worries. We do indeed require that users bring their own domain. I'll close this PR, reopen if that ever changes.

@pcarrier pcarrier closed this Apr 30, 2024
@pcarrier
Copy link
Contributor Author

pcarrier commented Apr 30, 2024

Just to clarify, if I rewrite the guide to get a free subdomain from any odd source, we're good to go?

@pcarrier pcarrier reopened this Apr 30, 2024
@bluwy
Copy link
Member

bluwy commented Apr 30, 2024

As long as it's a safe source, I suppose so, but I don't know on top of my head where this is possible.

One of the goals of this page is to have new users easily host their sites in their platform of choice, and if it's involves an external source to obtain a domain, it might not be worth it. So personally I'd stop there if so. The blog is still useful for those who already have a domain though.

@pcarrier
Copy link
Contributor Author

Enabled the use of subdomains of xmit.dev, created a new blog post, updated this PR.

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This looks good to me now.

@bluwy bluwy changed the title feat: add xmit to static-deploy.md docs(static-deploy): add xmit deployment guide May 1, 2024
@bluwy bluwy added the documentation Improvements or additions to documentation label May 1, 2024
@patak-dev patak-dev merged commit 72343be into vitejs:main May 1, 2024
12 checks passed
@pcarrier pcarrier deleted the patch-1 branch May 1, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants