Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add custom event types docs #16609

Merged
merged 7 commits into from
May 7, 2024

Conversation

FreeJ1nG
Copy link
Contributor

@FreeJ1nG FreeJ1nG commented May 6, 2024

Description

Add documentation for behavior specified in #16601

  • Add .d.ts suffix for file imports
  • Move Custom Event Types section from Plugin API to HMR API
  • Add backlink from Plugin API to HMR API referring to the moved section

Copy link

stackblitz bot commented May 6, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sapphi-red sapphi-red added the documentation Improvements or additions to documentation label May 7, 2024
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

docs/guide/api-plugin.md Show resolved Hide resolved
docs/guide/api-hmr.md Outdated Show resolved Hide resolved
docs/guide/api-hmr.md Outdated Show resolved Hide resolved
@FreeJ1nG
Copy link
Contributor Author

FreeJ1nG commented May 7, 2024

Whoops, sorry about the force push. I accidentally dragged some personal image onto my editor and pushed it to github unknowingly 😅

@FreeJ1nG FreeJ1nG changed the title docs(hmr-api): add custom event types docs docs: add custom event types docs May 7, 2024
docs/guide/api-plugin.md Outdated Show resolved Hide resolved
FreeJ1nG and others added 2 commits May 7, 2024 15:08
Co-authored-by: 翠 / green <green@sapphi.red>
…s, and just refer it in client-server communication
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@patak-dev patak-dev merged commit 66f12ab into vitejs:main May 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants