fix: fix rollup not respecting 'browser' field #283
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some libs are using
package.json#browser
field to differentiate server/browser implementation (e.g. axios). Without settingbrowser: true
,@rollup/plugin-node-resolve
will resolve with default files and results in code likeimport 'http'
in browser.This PR also upgrades
@rollup/plugin-commonjs
because it handles some commonjs package better in my case.