Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite): add marko file extensions #3073

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

DylanPiercey
Copy link
Contributor

Description

A Marko vite plugin is in the works however it is blocked by a couple hard coded file extension checks.

This PR adds support for the .marko file extension which makes creating a plugin possible.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

On the test front it is a bit tricky. I could create an example in the playground repo, but it's a bit of a chicken and egg situation with the @marko/vite plugin not yet being published.

@Shinigami92 Shinigami92 added the p2-nice-to-have Not breaking anything but nice to have (priority) label Apr 20, 2021
@patak-dev patak-dev merged commit d34fd88 into vitejs:main Apr 20, 2021
@DylanPiercey DylanPiercey deleted the marko-sfc-support branch April 21, 2021 22:04
@DylanPiercey
Copy link
Contributor Author

Thanks all for getting this through so quickly.
Happy to release our official Marko plugin! https://github.com/marko-js/vite

@patak-dev
Copy link
Member

That is awesome @DylanPiercey! It would be great if you could join our Discord server if you are not already there so you can share the plugin

@DylanPiercey
Copy link
Contributor Author

Good call @patak-js. For some reason I though I was already a part of that server, apparently not! Joining now 😄

TobiasMelen pushed a commit to TobiasMelen/vite that referenced this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants