test: coverage to settings related with backend integrations #3081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ElMassimo! Looks good, this will help a lot. Could you merge main to re-trigger the CI tests? There were a few fixes merges that should make this PR all green. |
9 tasks
patak-dev
reviewed
Apr 23, 2021
|
@ElMassimo if you merge main, the test suite should run with this fix #3185, which is going to show the correct error in windows instead of the timeout issue |
ElMassimo
commented
Apr 28, 2021
Shinigami92
approved these changes
Apr 29, 2021
patak-dev
approved these changes
Apr 29, 2021
patak-dev
changed the title
TobiasMelen
pushed a commit
to TobiasMelen/vite
that referenced
this pull request
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📖
This pull request adds a few tests to ensure there is coverage around
root,base,build.outDir,build.rollupOptions.input, andbase, which are configured differently when used through a backend integration such as Vite Ruby or Laravel Vite.Also, it prevents regressions (such as #2201) when serving files outside of Vite's root, which is also relevant for backend integrations.
Background 📜
This was originally merged in #2358 and later reverted in #3015 because the approach used in the test was causing problems.
After a discussion with @patak-js, we decided that it was worth adding a separate playground, and that we could leverage the opportunity to test
rootand other options that are relied upon in backend integrations.Screenshots 📷
The new playground, in the future it could be used to cover other configuration that is relevant for backend integrations.