Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use path type import, fix #4028 #4031

merged 1 commit into from Jun 30, 2021


Copy link

@IanVS IanVS commented Jun 29, 2021


Replaces #4029.

This seems to be a simpler way to fix the issue, and I've verified that it does in fact pass CI in linux in my own project.

Additional context

I believe that the type directive is for pointing to the name of a types package, and it just-so-happened to work in case-insensitive OSes. But from what we are trying to do, after reading, the path directive seems more appropriate, and does not suffer from being made lowercase.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • [] Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev changed the title fix: use path type import (fixes #4028) fix: use path type import, fix #4028 Jun 30, 2021
@patak-dev patak-dev merged commit e092e89 into vitejs:main Jun 30, 2021
@IanVS IanVS deleted the 4028-relative-import branch July 5, 2021 23:32
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants