Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): resolve license files correctly #4149

merged 2 commits into from Jul 6, 2021


Copy link
Sponsor Contributor

@hannoeru hannoeru commented Jul 6, 2021


rollup-plugin-license is using glob to scan the license file,
It uses relative paths (in monorepo it will starting with ../) as a pattern that is not supported in glob,
so it can't find license files that is outside process.cwd() in monorepo.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@hannoeru hannoeru changed the title fix: resolve license files correctly fix(build): resolve license files correctly Jul 6, 2021
@patak-dev patak-dev added the p1-chore 🧹 Doesn't change code behavior (priority) label Jul 6, 2021
@patak-dev patak-dev merged commit bf32b41 into vitejs:main Jul 6, 2021
@hannoeru hannoeru deleted the fix/read-license-files branch July 7, 2021 04:21
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
p1-chore 🧹 Doesn't change code behavior (priority)
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants