Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: run test error #4705

Merged
merged 1 commit into from Aug 24, 2021
Merged

fix: run test error #4705

merged 1 commit into from Aug 24, 2021

Conversation

y1d7ng
Copy link
Contributor

@y1d7ng y1d7ng commented Aug 24, 2021

Description

This commit caused an error in run test.

Additional context

The error log is:

The following dependencies are imported but could not be resolved:

vuex (imported by /home/runner/work/vite/vite/temp/optimize-deps/index.html)

In the current situation, optimize-deps's vuex will be installed in the current node_modules. When run test, the playground item will be copied to create the temp in the top directory, but the node_modules will not be copied over. Changing the vue version to 3.2.0 will make vuex installed in the top node_modules.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev merged commit 66ef227 into vitejs:main Aug 24, 2021
@y1d7ng y1d7ng deleted the hotfix/test branch August 24, 2021 07:08
ygj6 pushed a commit to ygj6/vite that referenced this pull request Aug 24, 2021
ygj6 pushed a commit to ygj6/vite that referenced this pull request Aug 24, 2021
ygj6 pushed a commit to ygj6/vite that referenced this pull request Aug 24, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants