Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: SSR externals on Windows #4980 #4986

Merged
merged 4 commits into from Sep 19, 2021
Merged

test: SSR externals on Windows #4980 #4986

merged 4 commits into from Sep 19, 2021

Conversation

untp
Copy link
Contributor

@untp untp commented Sep 19, 2021

Test for #4980

@untp
Copy link
Contributor Author

untp commented Sep 19, 2021

Before #4980
ubuntu pass, macos pass, windows fail
(https://github.com/untp/vite/actions/runs/1250638438)

After #4980
ubuntu pass, macos pass, windows pass
(https://github.com/vitejs/vite/pull/4986/checks)

@patak-dev patak-dev changed the title test: for #4980 test: SSR externals on Windows #4980 Sep 19, 2021
@patak-dev patak-dev merged commit 2e88ef5 into vitejs:main Sep 19, 2021
@patak-dev
Copy link
Member

Thanks a lot for taking the time to add the test cases and provide before and after results! I hope we see you around again 👍🏼

ygj6 pushed a commit to ygj6/vite that referenced this pull request Sep 22, 2021
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
@patak-dev patak-dev mentioned this pull request May 23, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants