Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): reorder dev server message #5141

merged 1 commit into from Sep 29, 2021


Copy link

@bluwy bluwy commented Sep 29, 2021


Currently, the dev server logs the status like this:

  vite v2.6.0 dev server running at:

Pre-bundling dependencies:
  (...and 10 more)
(this will be run only when your dependencies or config have changed)
  > Local: http://localhost:3000/
  > Network: use `--host` to expose

  ready in 1477ms.

This PR moves the prebundling message above the "vite dev server starting at" message.

This also indirectly fixed a strange quirk in the cli playground where it logged the server ready in 1632938015056.5159ms.

Additional context

  • Initially reported on Discord.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@patak-dev patak-dev merged commit 5fb3e0f into vitejs:main Sep 29, 2021
7 checks passed
@bluwy bluwy deleted the fix-dev-server-message branch September 30, 2021 02:36
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants