Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use micromatch for consistent glob matching #5610

Merged
merged 4 commits into from
Nov 11, 2021

Conversation

frandiox
Copy link
Contributor

Description

Closes #5511

This replaces minimatch with micromatch for consistency since that's what fast-glob uses internally.

As per Patak's comment, the docs that mentioned minimatch are now showing picomatch since that's what the Rollup ecosystem uses (and it's a subset of micromatch).
The docs that only mentions fast-glob are left unmodified. Should we change this also to picomatch?


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@frandiox frandiox changed the title Replace glob matcher fix: use micromatch for consistent glob matching Nov 10, 2021
@frandiox
Copy link
Contributor Author

@patak-js Anything else we should add to docs?

@patak-dev
Copy link
Member

I think we are fine for the moment 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Glob import does not refresh in SSR - minimatch vs micromatch
3 participants