fix: tolerate undefined parent in hookNodeResolve callback
#5664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parent module is undefined when a ESM module imports a CJS module. At this point, the `id` string is already an absolute path, so just return it.
aleclarson
added
the
p5-urgent
patak-dev
approved these changes
Nov 12, 2021
|
perfect,otherwise ssr playground run error in development |
|
Thanks for the PRs you have been working on lately @zhangyuang! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parent module is undefined when a ESM module imports a CJS module. At this point, the
idstring is already an absolute path, so just return it.This fixes a crash reported by SvelteKit and Shopify Hydrogen maintainers.