Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: simplify array handling #5734

Merged
merged 1 commit into from
Nov 18, 2021
Merged

Conversation

btea
Copy link
Collaborator

@btea btea commented Nov 18, 2021

refactor(plugin-vue): use Object.values instead of Object.keys
refactor(vite-client): use Array.from instead of [].slice

Description

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p1-chore Doesn't change code behavior (priority) label Nov 18, 2021
@patak-dev patak-dev changed the title refactor: method instead refactor: simplify array handling Nov 18, 2021
@patak-dev patak-dev merged commit 2cacc6b into vitejs:main Nov 18, 2021
@btea btea deleted the refactor-slice-keys branch November 18, 2021 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants