Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: correct config transpile comment #5735

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

sanyuan0704
Copy link
Contributor

Description

The comment is outdated and now vite uses esbuild to transpile es import syntax to require syntax.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sanyuan0704 sanyuan0704 changed the title chore: correct config transpile comment fix: correct config transpile comment Nov 18, 2021
@Shinigami92 Shinigami92 added the p1-chore Doesn't change code behavior (priority) label Nov 18, 2021
@patak-dev patak-dev changed the title fix: correct config transpile comment chore: correct config transpile comment Nov 18, 2021
@patak-dev patak-dev merged commit 4ffc9a5 into vitejs:main Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants