Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: css.modules.localsConvention is null by default, fix #5650 #5864

Merged
merged 1 commit into from
Nov 27, 2021
Merged

docs: css.modules.localsConvention is null by default, fix #5650 #5864

merged 1 commit into from
Nov 27, 2021

Conversation

ydcjeff
Copy link
Contributor

@ydcjeff ydcjeff commented Nov 27, 2021

Description

css.modules.localsConvention is null by default. This change was made in fee7393 and docs update missed in e4f78ef.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ydcjeff
Copy link
Contributor Author

ydcjeff commented Nov 27, 2021

Btw, netlify docs preview isn't running on PR?

@patak-dev
Copy link
Member

Btw, netlify docs preview isn't running on PR?

It is only running against main, and they aren't public AFAIK. It would be good to get more direct feedback though

@patak-dev patak-dev merged commit 8a8b296 into vitejs:main Nov 27, 2021
@ydcjeff ydcjeff deleted the docs/css.modules.localsConvention branch November 27, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants