Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-react): add jsx-runtime to optimizeDeps #6515

Conversation

stygian-desolator
Copy link
Contributor

Description

close #6215

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@iChip
Copy link

iChip commented Feb 24, 2022

@aleclarson single-line change, would appreciate your review

@aleclarson
Copy link
Member

aleclarson commented Mar 9, 2022

This fix is unsuitable, as it interferes with @vitejs/plugin-react intended behavior.

Imports to the react/jsx-runtime module are intentionally intercepted (see line 342 below) and replaced with a generated module.

const runtimeId = 'react/jsx-runtime'
// Adapted from https://github.com/alloc/vite-react-jsx
const viteReactJsx: Plugin = {
name: 'vite:react-jsx',
enforce: 'pre',
config() {
return {
optimizeDeps: {
include: ['react/jsx-dev-runtime']
}
}
},
resolveId(id: string) {
return id === runtimeId ? id : null
},

I will open a PR with a suitable fix. 👍

@aleclarson aleclarson closed this Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing react/jsx-runtime breaks dev builds
4 participants