Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add homepage url and keywords to package.json #6590

Merged
merged 3 commits into from
Jan 21, 2022

Conversation

GomezAgustin12
Copy link
Contributor

Description

On https://www.npmjs.com/package/vite the homepage URL goes to the Github repo and there are no keywords, I added the homepage to the package.json and some keywords.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Shinigami92
Shinigami92 previously approved these changes Jan 21, 2022
@Niputi Niputi changed the title fix: add homepage url and keywords to package.json chore: add homepage url and keywords to package.json Jan 21, 2022
@Niputi Niputi added the p1-chore Doesn't change code behavior (priority) label Jan 21, 2022
@Niputi
Copy link
Contributor

Niputi commented Jan 21, 2022

If we should have keywords, I think they should just be the same those we have on github

package.json Outdated Show resolved Hide resolved
patak-dev
patak-dev previously approved these changes Jan 21, 2022
package.json Outdated Show resolved Hide resolved
@patak-dev patak-dev merged commit e6495f0 into vitejs:main Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants