Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify deprecated exports key end with / #7302

Merged
merged 4 commits into from
Mar 13, 2022
Merged

Conversation

IronLu233
Copy link
Contributor

@IronLu233 IronLu233 commented Mar 13, 2022

Description

In #7267 it says we chould add a document for the deprecated property end with/ in package.json#exports field
fixs #7267

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

docs/config/index.md Outdated Show resolved Hide resolved
docs/config/index.md Outdated Show resolved Hide resolved
@bluwy bluwy changed the title docs: For deprecated exports key end with / docs: clarify deprecated exports key end with / Mar 13, 2022
@bluwy bluwy added the documentation Improvements or additions to documentation label Mar 13, 2022
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patak-dev
Copy link
Member

Hey @IronLu233, thanks for the PR! You are the 500th contributor to the Vite repo 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants