Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update define expression #7517

Merged
merged 3 commits into from May 10, 2022
Merged

test: update define expression #7517

merged 3 commits into from May 10, 2022

Conversation

ygj6
Copy link
Member

@ygj6 ygj6 commented Mar 30, 2022

Description

suddenly recall updating the test corresponding to #7511 馃槀

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@ygj6 ygj6 added the test label Mar 30, 2022
bluwy
bluwy previously approved these changes Mar 30, 2022
View reviewed changes
@bluwy bluwy added the p1-chore Doesn't change code behavior (priority) label Mar 30, 2022
@patak-dev patak-dev merged commit 86b29e7 into vitejs:main May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority) test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ygj6 @bluwy @patak-dev