Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugin-react): add vite peer dep #8083

Merged
merged 1 commit into from May 9, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented May 9, 2022

Description

Fix #8058

Additional context

Set as ^2.0.0. It doesn't seem like it's using features that requires a specific minor version.

vite is only used in the exported types now, but it makes sense to me to specify a version to show that it doesn't work with Vite v1 (for example)


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added p1-chore Doesn't change code behavior (priority) plugin: react labels May 9, 2022
@patak-dev patak-dev merged commit 2d978f7 into vitejs:main May 9, 2022
@bluwy bluwy deleted the plugin-react-peer-vite branch May 10, 2022 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[plugin-react] miss peerdependency vite
3 participants