Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lib): enable inlineDynamicImports for umd and iife #8126

merged 1 commit into from May 11, 2022


Copy link

@bluwy bluwy commented May 11, 2022


Fix #2982. Set inlineDynamicImports: true by default when building for umd and iife

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added p2-nice-to-have 🍰 Not breaking anything but nice to have (priority) feat: library mode labels May 11, 2022
@bluwy bluwy changed the title fix(lib): set inlineDynamicImports true for umd and iife fix(lib): enable inlineDynamicImports for umd and iife May 11, 2022
@patak-dev patak-dev merged commit 272a252 into vitejs:main May 11, 2022
@bluwy bluwy deleted the lib-umd-iife-dynamic-import branch May 12, 2022 02:57
Copy link

farhan-ct commented Jun 9, 2023

The original issue for me happen when trying to build code that has web worker. This did not resolve the issue. Adding the below code in vite config worked for me.

worker: {
  format: 'es'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
feat: library mode p2-nice-to-have 🍰 Not breaking anything but nice to have (priority)
None yet

Successfully merging this pull request may close these issues.

Library build does not work for UMD/IIFE bundles when Vite detects code that can be code-split
3 participants