Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly replace process.env.NODE_ENV #8283

merged 2 commits into from May 23, 2022


Copy link

@bluwy bluwy commented May 23, 2022


Fix #8210

Use same logic as definePlugin when resolving the value of process.env.NODE_ENV when replacing.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p3-minor-bug 🔨 An edge case that only affects very specific usage (priority) label May 23, 2022
Copy link
Member Author

bluwy commented May 23, 2022

Looks like there were incorrect tests before that's fixed in the second commit. When testing, process.env.NODE_ENV is test but it was checking based on mode, which is either development or production. I think relying on process.env.NODE_ENV is more correct.

@patak-dev patak-dev merged commit ec52baa into vitejs:main May 23, 2022
@bluwy bluwy deleted the fix-process-node-env-replacement branch May 23, 2022 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
p3-minor-bug 🔨 An edge case that only affects very specific usage (priority)
None yet

Successfully merging this pull request may close these issues.

vite forcibly replaced process.env.NODE_ENV as mode option
3 participants