Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix type of files in .eslintrc overrides #8369

Closed
wants to merge 1 commit into from
Closed

fix: fix type of files in .eslintrc overrides #8369

wants to merge 1 commit into from

Conversation

sosukesuzuki
Copy link
Contributor

Description

Fixes the type of files in .eslintrc overrides.

Additional context

My VSCode warns:

スクリーンショット 2022-05-29 1 36 49

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p1-chore Doesn't change code behavior (priority) label May 28, 2022
@sapphi-red
Copy link
Member

Shouldn't this be fixed in https://github.com/Shinigami92/eslint-define-config as eslint is working?
I didn't find any documentation about it and the document are using array. But it seems to accept a string.

@sosukesuzuki sosukesuzuki mentioned this pull request May 30, 2022
Merged
@Shinigami92
Copy link
Member

Shinigami92 commented May 31, 2022 •
edited
Loading

@sosukesuzuki sosukesuzuki deleted the type-check-for-root-js branch May 31, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees
No one assigned
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sosukesuzuki @sapphi-red @Shinigami92