Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make array acornInjectPlugins work (fixes #8410) #8415



Copy link

@sapphi-red sapphi-red commented May 31, 2022


fixes #8410

Type of acornInjectPlugins is (() => unknown)[] | (() => unknown) and Type of acorn.Parser.extend is

  this: typeof acorn.Parser,
  ...plugins: ((BaseParser: typeof acorn.Parser) => typeof acorn.Parser)[]
): typeof acorn.Parser

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sapphi-red sapphi-red added the p2-has-workaround 🍰 Bug, but has workaround (priority) label May 31, 2022
@patak-dev patak-dev merged commit 08d594b into vitejs:main May 31, 2022
@sapphi-red sapphi-red deleted the fix/make-acorn-inject-plugins-work branch June 1, 2022 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
p2-has-workaround 🍰 Bug, but has workaround (priority)
None yet

Successfully merging this pull request may close these issues.

Plugin conflict: [vite:css] plugins[i] is not a function
2 participants