Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore Playwright test results directory #8778

merged 1 commit into from Jun 30, 2022


Copy link


Vite watches everything in the test directory. Playwright can write a lot of changes if tracing is enabled.

I'd rather make everyone put their source code in a src directory or something rather than watch the entire root directory except for ignored directories, but this might be the best we can do until Vite 4 unless we want to make more breaking changes.

Additional context

This killed the SvelteKit tests and was extremely difficult to track down. There's probably a fair number of projects using both Vite and Playwright including Vite itself of course.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

netlify bot commented Jun 25, 2022

Deploy Preview for vite-docs-main ready!

Name Link
🔨 Latest commit 32aae5b
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link

Maybe this was the reason for some of the flackiness in our tests?

Copy link

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good for now, but long term we should implement something like #8341 (as you've commented there also)

@patak-dev patak-dev added the p3-downstream-blocker 🔨 Blocking the downstream ecosystem to work properly (priority) label Jun 30, 2022
@patak-dev patak-dev merged commit 314c09c into vitejs:main Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
p3-downstream-blocker 🔨 Blocking the downstream ecosystem to work properly (priority)
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants