Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip inline html #8789

merged 1 commit into from Jun 26, 2022

fix: skip inline html #8789

merged 1 commit into from Jun 26, 2022


Copy link

@bluwy bluwy commented Jun 26, 2022


Fix #5238

Additional context

I'm not sure if there are cases where you want to get the html url as base64

I also found #2909, which I can rebase later as it seems like a useful addition. Don't think it needs to apply to html files though.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

netlify bot commented Jun 26, 2022

Deploy Preview for vite-docs-main canceled.

Name Link
🔨 Latest commit dc22a05
🔍 Latest deploy log

@patak-dev patak-dev merged commit 4a6408b into vitejs:main Jun 26, 2022
@bluwy bluwy deleted the no-inline-html branch June 26, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Explicit URL Imports import as data:text/html;base64 not as a URL
2 participants