chore: ignore ts warning

[caoxiemeihao]

Description

Actually the error is already handled here.

vite/packages/vite/src/node/plugins/importAnalysis.ts

Lines 297 to 303 in ce790c4

	this.error(
	`Failed to resolve import "${url}" from "${path.relative(
	process.cwd(),
	importerFile
	)}". Does the file exist?`,
	pos
	)

So, we can ignore TS warnings.

Additional context

Version: 1.68.1 (Universal)
Commit: 30d9c6cd9483b2cc586687151bcbcd635f373630
Date: 2022-06-14T12:52:13.188Z
Electron: 17.4.7
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: 9.8.177.13-electron.0
OS: Darwin x64 19.6.0

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[netlify]

✅ Deploy Preview for vite-docs-main canceled.

Name	Link
🔨 Latest commit	36ee8fa
🔍 Latest deploy log	https://app.netlify.com/sites/vite-docs-main/deploys/62cab18eadd699000a2b3e9b

[bluwy]

I'm not getting the error like in the screenshot, by I remember it happening if using VS Code's typescript version. Perhaps this is the case too? Anyways I think it's good to anticipate this once we upgrade TypeScript, and maybe the simpler fix is to use a return after this.error instead so we don't need to use !.

We should also do this for importAnalysisBuild:

vite/packages/vite/src/node/plugins/importAnalysisBuild.ts

Lines 192 to 198 in ce790c4

	this.error(
	`Failed to resolve import "${url}" from "${path.relative(
	process.cwd(),
	importerFile
	)}". Does the file exist?`,
	pos
	)

[sapphi-red]

I'm not getting the error too. (TypeScript 4.6.4 (workspace), TypeScript 4.7.3 (vscode))

this.error has never as a return type, so I don't think the explicit return is needed?
https://github.com/rollup/rollup/blob/0ab16cc04b7d6dfe5bd14340ba7448085a379e25/src/rollup/types.d.ts#L193

[caoxiemeihao]

There is a notable!

This problem occurs when /packages/vite opened as VSCode path, but / does not.

---

[bluwy]

For me, even if there's no errors, when I hover resolved it still gives ResolvedId | null even when this.error should have removed the null possibility. Also after changing TS to vscode version, I had to reload the window to see the errors, maybe this happens for you too @sapphi-red. Anyways I think it's fine to add this workaround for now to appease TS.