Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: convert png diagrams to svg #9208

Merged
merged 6 commits into from
Jul 21, 2022
Merged

docs: convert png diagrams to svg #9208

merged 6 commits into from
Jul 21, 2022

Conversation

tony19
Copy link
Contributor

@tony19 tony19 commented Jul 19, 2022

Description

This converts the following PNG diagrams to SVG to enable translations:

This also adds the source file for the diagrams, which can be edited in Figma.

Preview:

Screen Shot 2022-07-21 at 12 00 22 AM

Screen Shot 2022-07-21 at 12 00 35 AM

Screen Shot 2022-07-21 at 12 00 35 AM

Screen Shot 2022-07-21 at 12 01 12 AM

Screen Shot 2022-07-21 at 12 01 00 AM

fixes #9207

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

bluwy
bluwy previously approved these changes Jul 20, 2022
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Nice touch to get in work in light/dark mode too. I'm not 100% sure of the borders around the image (feels a bit off from the docs design), but if it's just me we could also merge this soon then.

@patak-dev
Copy link
Member

Looks great! @tony19 if it is possible I also think these would look better without the borders.
By the way, thanks for all the reviews and PRs you have been doing! It's very helpful ❤️

@tony19
Copy link
Contributor Author

tony19 commented Jul 21, 2022

@bluwy @patak-dev Thanks! Ok, border removed! 👍

I think the diagrams need a few tweaks to improve legibility on mobile devices, but I'll create a different PR for that when I can.

@bluwy bluwy merged commit 6adb906 into vitejs:main Jul 21, 2022
@tony19 tony19 deleted the docs/png-to-svg branch October 23, 2022 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images in docs are not translated
3 participants