Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: intermittent failures in playground/server-origin test #9851

Merged
merged 1 commit into from
Aug 28, 2022
Merged

fix: intermittent failures in playground/server-origin test #9851

merged 1 commit into from
Aug 28, 2022

Conversation

tony19
Copy link
Contributor

@tony19 tony19 commented Aug 25, 2022

fix #9849

Description

Updates playground/vue-server-origin test to use localhost instead of https://vue-server-origin.test, which causes intermittent failures as the test browser tries to resolve it.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@tony19
Copy link
Contributor Author

tony19 commented Aug 28, 2022

The Mixed content and Redirect rules checks are stuck for some reason. They've been running since 2d ago.

@bluwy bluwy merged commit ec9ce4a into vitejs:main Aug 28, 2022
@bluwy
Copy link
Member

bluwy commented Aug 28, 2022

Looks like an issue on Netlify end. Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

playground/vue-server-origin test fails
2 participants