Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of ComponentDependencyResolver #8

Closed
wants to merge 6 commits into from

Commits on Dec 5, 2018

  1. Implementation of ComponentDependencyResolver

    PInvokes into hostpolicy.dll (which should live next to the runtime and thus always be reachable).
    If the PInvoke fails (missing hostpolicy.dll) we will fail for now.
    
    Adds tests for the API into CoreCLR repo. The main reason is that with corerun
    we can easily mock the hostpolicy.dll since there's none to start with.
    Writing the same tests in CoreFX or any other place which starts the runtime through
    hostpolicy would require test-only functionality to exist in either the class itself
    or in the hostpolicy.
    vitek-karas committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    1338f45 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    30d1471 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    72ffcf4 View commit details
    Browse the repository at this point in the history
  4. CDR native resolution tests

     Add native resolution tests
    vitek-karas committed Dec 5, 2018
    Configuration menu
    Copy the full SHA
    7625911 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2018

  1. Implements detailed error reporting for ComponentDependencyResolver.

    Registers error writer with the hostpolicy to receive detailed errors. Uses that in the exception.
    
    Modifications to the mock and the tests to be able to verify the functionality.
    vitek-karas committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    d7c0ef6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    77c0bc9 View commit details
    Browse the repository at this point in the history