-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace ajv with zod; simplified plugin API #1441
Conversation
export class PluginCoordinationType<T1 extends z.ZodTypeAny> { | ||
name: string; | ||
|
||
defaultValue: z.infer<T1>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be inferred from the schema itself? zod
probably has a notion of default values, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point - it does https://zod.dev/?id=default although I think for now I will just make an issue to investigate/address in a follow-up PR
* Use .js * Comments * Revert webpack plugin * Update cypress e2e tests * Add/move dev-docs * Update design-guidelines.md * Fix meta-updater * Revert config * Update design-guidelines.md * Update README.md * Update design-guidelines.md * Update design-guidelines.md * Update design-guidelines.md * Update rollup.config.js * Revert unrelated change * WIP: clean up lodash, mui, uuid imports * More import fixes * De-duplicate imports * Dev-docs about js imports * Use publint * isEqual * Fix tests * Dev-docs * Dev-docs linked from main README * Demo * Feedback
Fixes #1430
Fixes #1289
Towards #1401
Closes #1100
Towards #1515
Fixes #1514
Changes in this PR:
<Vitessce/>
to support upgrading from previous config schema versions - but plugin-agnostic<VitS/>
against the latest config schema - but plugin-agnostic<VitS/>
against a plugin-specific schema which accounts for coordination type value schemas and file type options schemasoptions
.@vitessce/schemas
andvitessce
re-exportz
from ZodsuperRefine
calls for schema upgrades to catch deprecated coordination types.window
(if this is needed it should be done in user-land) - instead they are passed as props to<Vitessce/>
/<VitS/>
@vitessce/plugins
and@vitessce/schemas
Updated docs
Future PRs:
DATA_TYPE_COORDINATION_VALUE_USAGE
autoIndependent
COMPONENT_COORDINATION_TYPES
Checklist
vitessce-python
andvitessce-r
if this is a release PR